Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for env variable for kafka_saslJaasConfig #276

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brunnjf
Copy link

@brunnjf brunnjf commented May 13, 2021

#30 added SASL support. Currently, in order to configure SASL plain, I think the best practice for kafdrop would be to configure the appropriate login module in the sasl.jaas.config property in kafka.properties. Something like...

sasl.jaas.config=org.apache.kafka.common.security.plain.PlainLoginModule required username="USER" password="PASSWORD";

This unfortunately puts user/pw information in plaintext in a file when running directly from a JAR.

Due to the nature of SpringBoot configuration, the change in this PR has the side effect of enabling configuration of the user/pw in the environment (kafka_saslJaasConfig) and through a command line argument (--kafka.saslJaasConfig) as is currently supported for brokers (kafka_brokerConnect/--kafka.brokerConnect).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant